diff --git a/handlers/actions.go b/handlers/actions.go index a2668c0..2c52ebf 100644 --- a/handlers/actions.go +++ b/handlers/actions.go @@ -300,11 +300,14 @@ func recoverBots() { func recoverBot(bm models.Player) error { // check if room still exists - if _, err := repo.RoomGetByID(context.Background(), bm.RoomID); err != nil { - return fmt.Errorf("no such room: %s; err: %w", bm.RoomID, err) + if bm.RoomID == nil { + return errors.New("bot has no room id") + } + if _, err := repo.RoomGetByID(context.Background(), *bm.RoomID); err != nil { + return fmt.Errorf("no such room: %s; err: %w", *bm.RoomID, err) } log.Debug("recovering bot", "bot", bm) - _, err := llmapi.NewBot(string(bm.Role), string(bm.Team), bm.Username, bm.RoomID, cfg, true) + _, err := llmapi.NewBot(string(bm.Role), string(bm.Team), bm.Username, *bm.RoomID, cfg, true) if err != nil { return err } diff --git a/handlers/auth.go b/handlers/auth.go index 6f8756e..28cee62 100644 --- a/handlers/auth.go +++ b/handlers/auth.go @@ -110,8 +110,11 @@ func HandleFrontLogin(w http.ResponseWriter, r *http.Request) { // room.PlayerList = append(room.PlayerList, fi.State.Username) fi.Room = room fi.List = nil - fi.State.RoomID = room.ID - repo.PlayerSetRoomID(r.Context(), fi.State.Username, room.ID) + fi.State.RoomID = &room.ID + if err := repo.PlayerSetRoomID(r.Context(), fi.State.Username, room.ID); err != nil { + abortWithError(w, err.Error()) + return + } // repo.RoomUpdate() // save full info instead // if err := saveFullInfo(r.Context(), fi); err != nil { @@ -191,6 +194,7 @@ func makeCookie(username string, remote string) (*http.Cookie, error) { return cookie, nil } +//nolint: unused func cacheGetSession(key string) (*models.Session, error) { userSessionB, err := cache.MemCache.Get(key) if err != nil { diff --git a/handlers/game.go b/handlers/game.go index 7da1e16..d04f3a4 100644 --- a/handlers/game.go +++ b/handlers/game.go @@ -38,7 +38,7 @@ func HandleCreateRoom(w http.ResponseWriter, r *http.Request) { abortWithError(w, msg) return } - fi.State.RoomID = room.ID + fi.State.RoomID = &room.ID fi.Room = room if err := repo.RoomCreate(r.Context(), room); err != nil { log.Error("failed to create a room", "error", err) @@ -223,7 +223,7 @@ func HandleJoinRoom(w http.ResponseWriter, r *http.Request) { return } // room.PlayerList = append(room.PlayerList, fi.State.Username) - fi.State.RoomID = room.ID + fi.State.RoomID = &room.ID fi.Room = room fi.List = nil if err := saveFullInfo(r.Context(), fi); err != nil { diff --git a/handlers/timer.go b/handlers/timer.go index d16cd9e..6cc8fe1 100644 --- a/handlers/timer.go +++ b/handlers/timer.go @@ -2,8 +2,8 @@ package handlers import ( "context" - "fmt" "gralias/models" + "strconv" "sync" "time" ) @@ -46,7 +46,7 @@ func StartTurnTimer(roomID string, duration time.Duration) { if err := repo.RoomUpdate(context.Background(), room); err != nil { log.Error("failed to save room", "error", err) } - notify(models.NotifyTurnTimerPrefix+room.ID, fmt.Sprintf("%d", room.Settings.TurnSecondsLeft)) + notify(models.NotifyTurnTimerPrefix+room.ID, strconv.FormatUint(uint64(room.Settings.TurnSecondsLeft), 10)) notifyBotIfNeeded(room) StopTurnTimer(roomID) return diff --git a/llmapi/main.go b/llmapi/main.go index 15fdd72..f8675eb 100644 --- a/llmapi/main.go +++ b/llmapi/main.go @@ -49,6 +49,7 @@ func convertToSliceOfStrings(value any) ([]string, error) { } } +//nolint: unused func (b *Bot) checkGuesses(tempMap map[string]any, room *models.Room) error { guesses, err := convertToSliceOfStrings(tempMap["guesses"]) if err != nil { @@ -539,5 +540,5 @@ func (b *Bot) CallLLM(prompt string) ([]byte, error) { return body, nil } // This line should not be reached because each error path returns in the loop. - return nil, fmt.Errorf("unknown error in retry loop") + return nil, errors.New("unknown error in retry loop") } diff --git a/repos/players_test.go b/repos/players_test.go index bf8a919..99f713e 100644 --- a/repos/players_test.go +++ b/repos/players_test.go @@ -38,8 +38,9 @@ func TestPlayersRepo_AddPlayer(t *testing.T) { repo := &RepoProvider{DB: db} + roomID := "test_room_player_1" player := &models.Player{ - RoomID: "test_room_player_1", + RoomID: &roomID, Username: "test_player_1", Team: "blue", Role: "player", @@ -61,8 +62,9 @@ func TestPlayersRepo_GetPlayer(t *testing.T) { repo := &RepoProvider{DB: db} + roomID := "test_room_player_2" player := &models.Player{ - RoomID: "test_room_player_2", + RoomID: &roomID, Username: "test_player_2", Team: "red", Role: "player", @@ -84,8 +86,9 @@ func TestPlayersRepo_DeletePlayer(t *testing.T) { repo := &RepoProvider{DB: db} + roomID := "test_room_player_3" player := &models.Player{ - RoomID: "test_room_player_3", + RoomID: &roomID, Username: "test_player_3", Team: "blue", Role: "player", @@ -95,7 +98,7 @@ func TestPlayersRepo_DeletePlayer(t *testing.T) { _, err := db.Exec(`INSERT INTO players (room_id, username, team, role, is_bot) VALUES (?, ?, ?, ?, ?)`, player.RoomID, player.Username, player.Team, player.Role, player.IsBot) assert.NoError(t, err) - err = repo.PlayerDelete(context.Background(), player.RoomID, player.Username) + err = repo.PlayerDelete(context.Background(), *player.RoomID, player.Username) assert.NoError(t, err) var count int