Compare commits
2 Commits
1b36ef938e
...
c83779b479
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
c83779b479 | ||
|
|
43b0fe3739 |
@@ -30,6 +30,7 @@ type Config struct {
|
||||
DBPATH string `toml:"DBPATH"`
|
||||
FilePickerDir string `toml:"FilePickerDir"`
|
||||
FilePickerExts string `toml:"FilePickerExts"`
|
||||
ImagePreview bool `toml:"ImagePreview"`
|
||||
EnableMouse bool `toml:"EnableMouse"`
|
||||
// embeddings
|
||||
RAGEnabled bool `toml:"RAGEnabled"`
|
||||
|
||||
66
docs/filepicker-search.md
Normal file
66
docs/filepicker-search.md
Normal file
@@ -0,0 +1,66 @@
|
||||
# Filepicker Search Implementation - Notes
|
||||
|
||||
## Goal
|
||||
Add `/` key functionality in filepicker (Ctrl+O) to filter/search files by name, similar to how `/` works in the main TUI textview.
|
||||
|
||||
## Requirements
|
||||
- Press `/` to activate search mode
|
||||
- Live case-insensitive filtering
|
||||
- `../` (parent directory) always visible
|
||||
- Show "No matching files" when nothing matches
|
||||
- Esc to cancel (return to main app for sending messages)
|
||||
- Enter to confirm search and close search input
|
||||
|
||||
## Approaches Tried
|
||||
|
||||
### Approach 1: Modify Flex Layout In-Place
|
||||
Add search input to the existing flex container by replacing listView with searchInput.
|
||||
|
||||
**Issues:**
|
||||
- tview's `RemoveItem`/`AddItem` causes UI freezes/hangs
|
||||
- Using `app.QueueUpdate` or `app.Draw` didn't help
|
||||
- Layout changes don't render properly
|
||||
|
||||
### Approach 2: Add Input Capture to ListView
|
||||
Handle `/` key in listView's SetInputCapture.
|
||||
|
||||
**Issues:**
|
||||
- Key events don't reach listView when filepicker is open
|
||||
- Global app input capture handles `/` for main textview search first
|
||||
- Even when checking `pages.GetFrontPage()`, the key isn't captured
|
||||
|
||||
### Approach 3: Global Handler with Page Replacement
|
||||
Handle `/` in global app input capture when filepicker page is frontmost.
|
||||
|
||||
**Issues:**
|
||||
- Search input appears but text is invisible (color issues)
|
||||
- Enter/Esc not handled - main TUI captures them
|
||||
- Creating new pages adds on top instead of replacing, causing split-screen effect
|
||||
- Enter on file item opens new filepicker (page stacking issue)
|
||||
|
||||
### Approach 4: Overlay Page (Modal-style)
|
||||
Create a new flex with search input on top and filepicker below, replace the page.
|
||||
|
||||
**Issues:**
|
||||
- Page replacement causes split-screen between main app and filepicker
|
||||
- Search input renders but invisible text
|
||||
- Enter/Esc handled by main TUI, not search input
|
||||
- State lost when recreating filepicker
|
||||
|
||||
## Root Causes
|
||||
|
||||
1. **tview UI update issues**: Direct manipulation of flex items causes freezes or doesn't render
|
||||
2. **Input capture priority**: Even with page overlay, main TUI's global input capture processes keys first
|
||||
3. **Esc key conflict**: Esc is used for sending messages in main TUI, and it's hard to distinguish when filepicker is open
|
||||
4. **Focus management**: tview's focus system doesn't work as expected with dynamic layouts
|
||||
|
||||
## Possible Solutions (Not Tried)
|
||||
|
||||
1. **Use tview's built-in Filter method**: ListView has a SetFilterFunc that might work
|
||||
2. **Create separate search primitive**: Instead of replacing list, use a separate text input overlay
|
||||
3. **Different key for search**: Use a key that isn't already mapped in main TUI
|
||||
4. **Fork/extend tview**: May need to modify tview itself for better dynamic UI updates
|
||||
5. **Use form with text input**: tview.Forms might handle input better
|
||||
|
||||
## Current State
|
||||
All search-related changes rolled back. Filepicker works as before without search functionality.
|
||||
@@ -135,6 +135,9 @@ func makePropsTable(props map[string]float32) *tview.Table {
|
||||
// Reconfigure the app's mouse setting
|
||||
app.EnableMouse(cfg.EnableMouse)
|
||||
})
|
||||
addCheckboxRow("Image Preview (file picker)", cfg.ImagePreview, func(checked bool) {
|
||||
cfg.ImagePreview = checked
|
||||
})
|
||||
addCheckboxRow("Auto turn (for cards with many chars)", cfg.AutoTurn, func(checked bool) {
|
||||
cfg.AutoTurn = checked
|
||||
})
|
||||
|
||||
66
tables.go
66
tables.go
@@ -2,6 +2,7 @@ package main
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"image"
|
||||
"os"
|
||||
"path"
|
||||
"strings"
|
||||
@@ -823,9 +824,25 @@ func makeFilePicker() *tview.Flex {
|
||||
statusView := tview.NewTextView()
|
||||
statusView.SetBorder(true).SetTitle("Selected File").SetTitleAlign(tview.AlignLeft)
|
||||
statusView.SetTextColor(tcell.ColorYellow)
|
||||
// Layout - only include list view and status view
|
||||
// Image preview pane
|
||||
var imgPreview *tview.Image
|
||||
if cfg.ImagePreview {
|
||||
imgPreview = tview.NewImage()
|
||||
imgPreview.SetBorder(true).SetTitle("Preview").SetTitleAlign(tview.AlignLeft)
|
||||
}
|
||||
// Horizontal flex for list + preview
|
||||
var hFlex *tview.Flex
|
||||
if cfg.ImagePreview && imgPreview != nil {
|
||||
hFlex = tview.NewFlex().SetDirection(tview.FlexColumn).
|
||||
AddItem(listView, 0, 3, true).
|
||||
AddItem(imgPreview, 0, 2, false)
|
||||
} else {
|
||||
hFlex = tview.NewFlex().SetDirection(tview.FlexColumn).
|
||||
AddItem(listView, 0, 1, true)
|
||||
}
|
||||
// Main vertical flex
|
||||
flex := tview.NewFlex().SetDirection(tview.FlexRow)
|
||||
flex.AddItem(listView, 0, 3, true)
|
||||
flex.AddItem(hFlex, 0, 3, true)
|
||||
flex.AddItem(statusView, 3, 0, false)
|
||||
// Refresh the file list
|
||||
var refreshList func(string)
|
||||
@@ -846,6 +863,7 @@ func makeFilePicker() *tview.Flex {
|
||||
// We're at the root ("/") and trying to go up, just don't add the parent item
|
||||
} else {
|
||||
listView.AddItem("../ [gray](Parent Directory)[-]", "", 'p', func() {
|
||||
imgPreview.SetImage(nil)
|
||||
refreshList(parentDir)
|
||||
dirStack = append(dirStack, parentDir)
|
||||
currentStackPos = len(dirStack) - 1
|
||||
@@ -869,6 +887,7 @@ func makeFilePicker() *tview.Flex {
|
||||
// Capture the directory name for the closure to avoid loop variable issues
|
||||
dirName := name
|
||||
listView.AddItem(dirName+"/ [gray](Directory)[-]", "", 0, func() {
|
||||
imgPreview.SetImage(nil)
|
||||
newDir := path.Join(dir, dirName)
|
||||
refreshList(newDir)
|
||||
dirStack = append(dirStack, newDir)
|
||||
@@ -898,6 +917,43 @@ func makeFilePicker() *tview.Flex {
|
||||
}
|
||||
// Initialize the file list
|
||||
refreshList(startDir)
|
||||
// Update image preview when selection changes
|
||||
if cfg.ImagePreview && imgPreview != nil {
|
||||
listView.SetChangedFunc(func(index int, mainText, secondaryText string, rune rune) {
|
||||
itemText, _ := listView.GetItemText(index)
|
||||
if strings.HasPrefix(itemText, "Exit file picker") || strings.HasPrefix(itemText, "../") {
|
||||
imgPreview.SetImage(nil)
|
||||
return
|
||||
}
|
||||
actualItemName := itemText
|
||||
if bracketPos := strings.Index(itemText, " ["); bracketPos != -1 {
|
||||
actualItemName = itemText[:bracketPos]
|
||||
}
|
||||
if strings.HasSuffix(actualItemName, "/") {
|
||||
imgPreview.SetImage(nil)
|
||||
return
|
||||
}
|
||||
if !isImageFile(actualItemName) {
|
||||
imgPreview.SetImage(nil)
|
||||
return
|
||||
}
|
||||
filePath := path.Join(currentDisplayDir, actualItemName)
|
||||
go func() {
|
||||
file, err := os.Open(filePath)
|
||||
if err != nil {
|
||||
app.QueueUpdate(func() { imgPreview.SetImage(nil) })
|
||||
return
|
||||
}
|
||||
defer file.Close()
|
||||
img, _, err := image.Decode(file)
|
||||
if err != nil {
|
||||
app.QueueUpdate(func() { imgPreview.SetImage(nil) })
|
||||
return
|
||||
}
|
||||
app.QueueUpdate(func() { imgPreview.SetImage(img) })
|
||||
}()
|
||||
})
|
||||
}
|
||||
// Set up keyboard navigation
|
||||
flex.SetInputCapture(func(event *tcell.EventKey) *tcell.EventKey {
|
||||
switch event.Key() {
|
||||
@@ -905,6 +961,9 @@ func makeFilePicker() *tview.Flex {
|
||||
pages.RemovePage(filePickerPage)
|
||||
return nil
|
||||
case tcell.KeyBackspace2: // Backspace to go to parent directory
|
||||
if cfg.ImagePreview && imgPreview != nil {
|
||||
imgPreview.SetImage(nil)
|
||||
}
|
||||
if currentStackPos > 0 {
|
||||
currentStackPos--
|
||||
prevDir := dirStack[currentStackPos]
|
||||
@@ -954,6 +1013,9 @@ func makeFilePicker() *tview.Flex {
|
||||
}
|
||||
// Navigate to the selected directory
|
||||
logger.Info("going to the dir", "dir", targetDir)
|
||||
if cfg.ImagePreview && imgPreview != nil {
|
||||
imgPreview.SetImage(nil)
|
||||
}
|
||||
refreshList(targetDir)
|
||||
dirStack = append(dirStack, targetDir)
|
||||
currentStackPos = len(dirStack) - 1
|
||||
|
||||
Reference in New Issue
Block a user